On Wed, May 26, 2010 at 6:48 PM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
>
>>
>> If output file is in non-block mode, in file should be seekable to avoid data
>> losing.
>
> Like the previous patch, I don't agree.
I don't think it isn't an API change, as the current manual page says:
" Presently (Linux 2.6.9): in_fd, must correspond to a file which sup-
ports mmap(2)-like operations (i.e., it cannot be a socket); "
and if file supports mmap-like operations, it should support pread too.
>
>>
>> do_splice_from() shouldn't use sd->pos, as sd->pos is for file reading,
>> file->f_pos should be used instead.
>
> This sounds sane.
>
> These changes look like three cadidates for separate patches. Could
> you please split this patch up, and submit the first and last change
> as a separate patch?
>
OK. I'll do that later after all the issues are concluded.
--
Regards，
Changli Gao(xiaosuo@xxxxxxxxx)
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
