On Wed, May 19, 2010 at 04:24:50PM -0400, Josef Bacik wrote:
> V1->V2:
> -Changed dio_end_io to EXPORT_SYMBOL_GPL
> -Removed the own_submit blockdev dio helper
> -Removed the boundary change
patch version changelogs go below the --- header so they don't go into
the commit message. Also makes reading the patch description a lot
easier. Also applies to all the other patches in the series.
> +void dio_end_io(struct bio *bio, int error)
> +{
> + struct dio *dio = bio->bi_private;
> +
> + if (dio->is_async)
> + dio_bio_end_aio(bio, error);
> + else
> + dio_bio_end_io(bio, error);
> +}
> +EXPORT_SYMBOL_GPL(dio_end_io);
This one needs a good kerneldoc comment.
> - submit_bio(dio->rw, bio);
> + if (!dio->submit_io)
> + submit_bio(dio->rw, bio);
> + else
> + dio->submit_io(dio->rw, bio, dio->inode,
> + dio->logical_offset_in_bio);
'd reverse the if condition - no need for an inversion here.
if (dio->submit_io) {
dio->submit_io(dio->rw, bio, dio->inode,
dio->logical_offset_in_bio);
} else {
submit_bio(dio->rw, bio);
}
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
