On Wed 19-05-10 10:02:08, Dmitry Monakhov wrote: > > Signed-off-by: Dmitry Monakhov <dmonakhov@xxxxxxxxxx> > --- > fs/ext2/ialloc.c | 5 ++++- > fs/ext2/inode.c | 11 +++++++++-- > fs/ext2/namei.c | 40 ++++++++++++++++++++++++++++++---------- > 3 files changed, 43 insertions(+), 13 deletions(-) > ... > diff --git a/fs/ext2/namei.c b/fs/ext2/namei.c > index 71efb0e..d47e549 100644 > --- a/fs/ext2/namei.c > +++ b/fs/ext2/namei.c > @@ -157,7 +162,9 @@ static int ext2_symlink (struct inode * dir, struct dentry * dentry, > if (l > sb->s_blocksize) > goto out; > > - dquot_initialize(dir); > + err = dquot_initialize(dir); > + if (err) > + return err; Should be 'goto out' for consistency and in other functions below as well.. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
