On Mon, 2010-05-17 at 15:10 +0100, David Woodhouse wrote: > Now you're just reimplementing iget(). > > Can we just use iget_locked() to get the appropriate inode (using the > mtd device number as the inode number)? Then we don't need to bother > storing it in mtd->inode at all, and we can iput() the last refcount on > it when the chardevice is closed -- we don't need it to stick around > until the MTD device is destroyed. ... and we don't _want_ it to stick around until the MTD device is destroyed, either. We may actually unload the mtdchar module and its inodes will be destroyed when we unregister the fs type; we don't want stale pointers to them hanging around to be reused if/when we reload the mtdchar module later. I've committed a version which keeps it entirely within the mtdchar code: http://git.infradead.org/mtd-2.6.git/commitdiff/cd874237 Thanks. -- David Woodhouse Open Source Technology Centre David.Woodhouse@xxxxxxxxx Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
