On Wed 12-05-10 15:44:11, Christoph Hellwig wrote:
> Currently the VFS calls into the quotactl interface for unmounting
> filesystems. This means filesystems with their own quota handling
> can't easily distinguish between user-space originating quotaoff
> and an unount. Instead move the responsibily of the unmount handling
> into the filesystem to be consistent with all other dquot handling.
>
> Note that we do call dquot_disable a lot later now, e.g. after
> a sync_filesystem. But this is fine as the quota code takes care
> of writing out the quota file by itself.
Well, we don't really write quota file by ourselves but we do the writes
via blockdev's mapping and that is synced after put_super is called so you
are right it should be fine.
> Index: linux-2.6/fs/ocfs2/super.c
> ===================================================================
> --- linux-2.6.orig/fs/ocfs2/super.c 2010-05-10 22:42:36.910005803 +0200
> +++ linux-2.6/fs/ocfs2/super.c 2010-05-10 23:22:59.035004827 +0200
> @@ -1595,6 +1595,8 @@ static void ocfs2_put_super(struct super
> {
> mlog_entry("(0x%p)\n", sb);
>
> + dquot_disable(sb, -1, DQUOT_LIMITS_ENABLED);
> +
OCFS2 disables quotas completely on it's own slightly later in
ocfs2_dismount_volume so you can just remove this.
Otherwise the patch looks fine.
Honza
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
