On Fri, May 14, 2010 at 4:03 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote: > On Thu, 2010-05-13 at 22:08 +0800, Changli Gao wrote: >> > NAK, I really utterly dislike that inatomic argument. The alloc side >> > doesn't function in atomic context either. Please keep the thing >> > symmetric in that regards. >> > >> >> There are some users, who release memory in atomic context. for >> example: fs/file.c: fdmem. > > urgh, but yeah, aside from not using vmalloc to allocate fd tables one > needs to deal with this. > > But if that is the only one, I'd let them do the workqueue thing that's > already there. If there really are more people wanting to do this, then > maybe add: kvfree_atomic(). > Tetsuo has pointed another one in apparmor. http://kernel.ubuntu.com/git?p=jj/ubuntu-lucid.git;a=blobdiff;f=security/apparmor/match.c;h=d2cd55419acfcae85cb748c8f837a4384a3a0d29;hp=afc2dd2260edffcf88521ae86458ad03aa8ea12c;hb=f5eba4b0a01cc671affa429ba1512b6de7caeb5b;hpb=abdff9ddaf2644d0f9962490f73e030806ba90d3 , though apparmor hasn't been merged into mainline. -- Regards, Changli Gao(xiaosuo@xxxxxxxxx) -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html