Re: [patch] bio-integrity: use hardware sectors instead of block layer sectors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dan Carpenter wrote:
> Smatch tagged this code as suspicious because we never use the
> "nr_sectors" variable.  Looking at the code, I think we did intend to
> use "nr_sectors" instead of "sectors" when we call
> bio_integrity_mark_tail().
> 
> The difference between "sectors" and "nr_sectors" is that "sectors" is in
> terms of 512 byte sectors and "nr_sectors" is in terms of hardware 
> sectors.  They are only different for 4k sector devices.

That code is so asking for the variable to be called "hw_sectors".

-- Jamie
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux