On 2010-04-30, at 15:33, Andrew Morton wrote: > On Thu, 29 Apr 2010 10:14:06 +0530 > Nikanth Karthikesan <knikanth@xxxxxxx> wrote: >> diff --git a/fs/open.c b/fs/open.c >> index 74e5cd9..4ca57c9 100644 >> --- a/fs/open.c >> +++ b/fs/open.c >> @@ -405,17 +405,26 @@ int do_fallocate(struct file *file, int mode, loff_t offset, loff_t len) >> if (S_ISFIFO(inode->i_mode)) >> return -ESPIPE; >> >> - /* >> - * Let individual file system decide if it supports preallocation >> - * for directories or not. >> - */ >> - if (!S_ISREG(inode->i_mode) && !S_ISDIR(inode->i_mode)) >> - return -ENODEV; >> - >> - /* Check for wrap through zero too */ >> - if (((offset + len) > inode->i_sb->s_maxbytes) || ((offset + len) < 0)) >> + /* Check for wrap through zero */ >> + if (offset+len < 0) >> return -EFBIG; > > I suggest that this test be moved up to where the function tests `if > (offset < 0 || len <= 0)' - it seems more logical. Sometimes the order of these checks is mandated by POSIX because of the error return code. I'm not saying for sure that is the case here, but sometimes logic doesn't come into the specification. :-/ Cheers, Andreas -- Andreas Dilger Lustre Technical Lead Oracle Corporation Canada Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
