On Thu, Apr 29 2010, Boaz Harrosh wrote:
>
> The patch: add bdi backing to mount session
> (b3d0ab7e60d1865bb6f6a79a77aaba22f2543236)
>
> Has a bug in the placement of the bdi member at
> struct exofs_sb_info. The layout member must be kept
> last.
>
> Signed-off-by: Boaz Harrosh <bharrosh@xxxxxxxxxxx>
> ---
> fs/exofs/exofs.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/exofs/exofs.h b/fs/exofs/exofs.h
> index 5437327..22721b2 100644
> --- a/fs/exofs/exofs.h
> +++ b/fs/exofs/exofs.h
> @@ -85,6 +85,7 @@ struct exofs_sb_info {
> u32 s_next_generation; /* next gen # to use */
> atomic_t s_curr_pending; /* number of pending commands */
> uint8_t s_cred[OSD_CAP_LEN]; /* credential for the fscb */
> + struct backing_dev_info bdi; /* register our bdi with VFS */
>
> struct pnfs_osd_data_map data_map; /* Default raid to use
> * FIXME: Needed ?
> @@ -93,7 +94,6 @@ struct exofs_sb_info {
> struct exofs_layout layout; /* Default files layout,
> * contains the variable osd_dev
> * array. Keep last */
> - struct backing_dev_info bdi;
> struct osd_dev *_min_one_dev[1]; /* Place holder for one dev */
> };
Irk, silly mistake. Apparently I missed the comment, and I did move it
prior to _min_one_dev[] but didn't think enough about it.
Acked-by: Jens Axboe <jens.axboe@xxxxxxxxxx>
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
