On Thu, Apr 15, 2010 at 06:21:35PM +0100, Mel Gorman wrote: > From: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> > > Now very lots function in vmscan have `priority' argument. It consume > stack slightly. To move it on struct scan_control reduce stack. I don't like this much because it obfuscates value communication. Functions no longer have obvious arguments and return values, as it's all passed hidden in that struct. Do you think it's worth it? I would much rather see that thing die than expand on it... -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html