On Fri 26-03-10 14:07:00, Francis Moreau wrote: > This patch removes a useless call to brelse(bitmap_bh) since at that > point bitmap_bh is NULL. > > It also converts the last brelse(bitmap_bh) into a __brelse(bitmap_bh) > since at that point bitmap_bh is no more NULL. The cleanup looks fine. Only I'd use normal brelse instead of __brelse at the end. The compiler should figure out itself that the check is unnecessary (if not, the cost of extra test is negligible in that path anyway) and you don't have to think twice when looking at the function. Also you don't have to initialize bitmap_bh to NULL after your cleanups. So I've taken your patch with these two minor changes. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
