On Mon 05-04-10 13:44:54, Dmitry Monakhov wrote: > Currently quota is able to return real error code to caller. > Now it is possible to fix long standing bug with silent quota > corruption in dquot_transfer. > From 5e529864261c7bffe32a8b3d45d7b51749b4512f Mon Sep 17 00:00:00 2001 > From: Dmitry Monakhov <dmonakhov@xxxxxxxxxx> > Date: Mon, 5 Apr 2010 13:02:18 +0400 > Subject: [PATCH] quota: handle io errors in dquot_transfer > > Currently if one of dquot structures absent due to some io errors > dquot_transfer will ignore corresponding quotatype. Which is very > bad because result in silent quota inconsistency. But because we were unable to read some quota structure, quota already *is* inconsistent. So it's not like this particular operation would introduce the inconsistency. > Sane implementation must return corresponding error to caller. But sure I agree we should return the fact that we stumbled on quota inconsistency the same way we do it for dquot_alloc_space or dquot_free_space. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
