On Wed, Mar 31, 2010 at 11:17:39AM +0400, dmonakhov@xxxxxxxxxx wrote: > Dave Chinner <david@xxxxxxxxxxxxx> writes: > > On Wed, Mar 31, 2010 at 09:20:17AM +0400, Dmitry Monakhov wrote: > >> BTW: I've attached my testcase. I hope it will be useful for you. > >> It able to catch quota inconsistency caused by incorrect symlink > >> handling, but it is not reliable for writepage/fallocate bug in ext4. .... > > There's already a "_require_quota()" function in common.quota that > Yep. overlooked this one. > > checks if the filesystem being tested supports quotas and that the > > quota tools are installed. Can you add these checks to that > > function? > > > > _require_quota also calls _notrun directly, so no need for the > > quota_supported variable, either. > > > > Also, can you use 8 space tabs for indenting? > Ok, will redo accruing to all your comments. To make the testcase more > useful i want to perform grep dmesg. But currently this technique > is not used in xfs-testcase. It hasn't been used because in the past kernel output is has not been needed to report a test success or fail. If the test fails, and there's pertinent infomration in the kernel log, then normally the developer grabs that him/herself after the failure. > How can i do it in a convenient way? What information do you want to grab from the kernel log? If you make the test linux platform specific (IIRC you already have), then you could probably just run dmesg and sed/awk/grep/perl the output to get what you want. Lots of tests take output from something and then filter it down like this to get the required, anonymised information to match against the golden output... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
