On Fri, 2010-03-12 at 21:41 +0800, Wu Fengguang wrote: > Follow the comment by Eric: > > Until the FMODE_ and O_ bits do not overload I think we need to check > FMODE_EXEC and FMODE_NONOTIFY (if you have that one) inside fcntl_init() > as well. I guess I'll send a patch to someone ?Al? to add FMODE_EXEC to > the list.... > > CC: Eric Paris <eparis@xxxxxxxxxx> > Signed-off-by: Wu Fengguang <fengguang.wu@xxxxxxxxx> > --- > fs/fcntl.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- linux-mm.orig/fs/fcntl.c 2010-03-12 21:27:12.000000000 +0800 > +++ linux-mm/fs/fcntl.c 2010-03-12 21:38:51.000000000 +0800 > @@ -748,7 +748,8 @@ static int __init fcntl_init(void) > O_TRUNC | O_APPEND | O_NONBLOCK | > __O_SYNC | O_DSYNC | FASYNC | > O_DIRECT | O_LARGEFILE | O_DIRECTORY | > - O_NOFOLLOW | O_NOATIME | O_CLOEXEC > + O_NOFOLLOW | O_NOATIME | O_CLOEXEC | > + FMODE_EXEC > )); I think we need to update the hweight as well, otherwise I sure hope this would panic.... -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
