On Mon 08-03-10 12:13:08, Christoph Hellwig wrote: > On Mon, Mar 08, 2010 at 06:11:34PM +0100, Jan Kara wrote: > > On Sat 06-03-10 08:17:53, Christoph Hellwig wrote: > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > Christoph, I see that you have removed the 'mask' argument of > > dquot_transfer. Actually, this has been added a short time ago as > > a preparation for the project_id patches of Dmitry. Since his patches > > seem to be getting in a good shape, I'd prefer not to make his life > > harder and leave __dquot_transfer as is for now so that he can hook > > into it. > > Dmitri will have to add code to grab the project ID somewhere. His > patch made that easier when the two functions were split over an > indirect call boundary, but now that this is gone it's not needed > anymore. One line still needs to be added, and that's in the ne > dquot_transfer. Hmm, but dquot_transfer gets new uid/gid from struct iattr. So either we have to extend struct iattr to accompany also project_id changes (fine with me) or we have to keep interface similar to __dquot_transfer. Do you have any preference? Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
