On Mon 01-03-10 04:50:52, Christoph Hellwig wrote: > On Thu, Feb 25, 2010 at 12:14:14AM +0100, Jan Kara wrote: > > On Sat 20-02-10 06:51:05, Christoph Hellwig wrote: > > > Get rid of the transfer dquot operation - it is now always called from > > > the filesystem and if a filesystem really needs it's own (which none > > > currently does) it can just call into it's own routine directly. > > > > > > Rename the now static low-level dquot_transfer helper to __dquot_transfer > > > and vfs_dq_transfer to dquot_transfer to have a consistent namespace, > > > and make the new dquot_transfer return a normal negative errno value > > > which all callers expect. > > Looks good. I just wonder - if you made dquot_transfer() return error > > code, shouldn't also dquot_alloc_inode, dquot_alloc_space and similar > > return error code instead of 1? It would seem more consistent. > > Probably - I can do that in another pass if you haven't done it yet. I've already done it. See commits 3a3d2903d3e9aaba9ca154606cf2f2613839b079 and bff3333e868578990f6fe794a7cba0c74bd433ac in my linux-fs-2.6 tree. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
