On 2010-02-22, at 03:30, Karel Zak wrote:
The stable util-linux-ng 2.17.1 release is available at ftp://ftp.kernel.org/pub/linux/utils/util-linux-ng/v2.17/ Feedback and bug reports, as always, are welcomed.
Hi Karel,attached is an updated version of the ZFS device detection. It includes support for extracting the pool name (LABEL) along with the pool_guid (UUID).
One question I had was regarding naming of the TYPE. Currently we are using "zfs" for this, but the current code is only really detecting the volume information and has noting to do with mountable filesystems. Extracting filesystem names/mountpoints/guids is basically impossible at this stage w/o actually having ZFS active (in a similar manner that extracting ext2/3/4 filesystem information from an unconfigured LVM PV is impossible).
Should we rename the TYPE to be "zfs_vdev" (ZFS equivalent to "lvm2pv") instead of the current "zfs"? It is probably more desirable to keep "zfs" for future filesystem mountpoint identification. For now I've left it as "zfs" but wouldn't mind changing it now while there are not any real users of this.
Have you considered adding CONTAINER or similar identification to the blkid.tab file, so that it is possible to determine that the filesystem with LABEL="home" is on CONTAINER="39u4yr-f5WW-dtD7-jDfr- usGd-pYWf-qy6xKE", which in turn is the UUID of an lvm2pv on /dev/sda2?
Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc.
Attachment:
util-linux-blkid-zfs.diff
Description: Binary data
