Re: [PATCH 1/8] dquot: cleanup space allocation / freeing routines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat 20-02-10 06:51:02, Christoph Hellwig wrote:
> Get rid of the alloc_space, free_space, reserve_space, claim_space and
> release_rsv dquot operations - they are always called from the filesystem
> and if a filesystem really needs their own (which none currently does)
> it can just call into it's own routine directly.
> 
> Move shared logic into the common __dquot_alloc_space,
> dquot_claim_space_nodirty and __dquot_free_space low-level methods,
> and rationalize the wrappers around it to move as much as possible
> code into the common block for CONFIG_QUOTA vs not.  Also rename
> all these helpers to be named dquot_* instead of vfs_dq_*.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
  Looks fine. I've just fixed up compilation failure in case CONFIG_QUOTA
was disabled and inverted numbers passed as 'warn' argument because they
were historically the other way around than the name of the argument
suggests.

								Honza

-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux