Re: [PATCH v4 1/4] pidfs: improve multi-threaded exec and premature thread-group leader exit polling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/20, Christian Brauner wrote:
>
> Co-Developed-by: Oleg Nesterov <oleg@xxxxxxxxxx>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
> Signed-off-by: Christian Brauner <brauner@xxxxxxxxxx>
> ---
>  fs/pidfs.c      | 9 +++++----
>  kernel/exit.c   | 6 +++---
>  kernel/signal.c | 3 +--
>  3 files changed, 9 insertions(+), 9 deletions(-)

Thanks, LGTM.

Todo:

	- As we already discussed, do_notify_pidfd() can be called
	  twice from exit_notify() paths, we can avoid this.

	  But this connects to another minor issue:

	- With this change, debuggers can no longer use PIDFD_THREAD.
	  I guess we don't really care, I don't think PIDFD_THREAD was
	  ever used for this purpose. but perhaps we can change this
	  or at least document somewhere...

I'll try to do this but not today and (most probably) not tomorrow.

Oleg.





[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux