On Wed, Mar 19, 2025 at 09:17:30AM +0100, Christoph Hellwig wrote: > I'd move the iomap_iter_advance into iomap_read_inline_data, just like > we've pushed it down as far as possible elsewhere, e.g. something like > the patch below. Although with that having size and length puzzles > me a bit, so maybe someone more familar with the code could figure > out why we need both, how they can be different and either document > or eliminate that. ... and this doesn't even compile because it breaks write_begin. So we'll need to keep it in the caller, but maybe without the goto and just do the plain advance on length?
