Re: [PATCH v6 12/13] xfs: commit CoW-based atomic writes atomically

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH v6 12/13] xfs: commit CoW-based atomic writes atomically
From: John Garry <john.g.garry@xxxxxxxxxx>
Date: Mon, 17 Mar 2025 09:43:33 +0000
Cc: brauner@xxxxxxxxxx, djwong@xxxxxxxxxx, cem@xxxxxxxxxx, dchinner@xxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, ojaswin@xxxxxxxxxxxxx, ritesh.list@xxxxxxxxx, martin.petersen@xxxxxxxxxx, tytso@xxxxxxx, linux-ext4@xxxxxxxxxxxxxxx
In-reply-to: <20250317065651.GA28079@lst.de>
Organization: Oracle Corporation
User-agent: Mozilla Thunderbird

On 17/03/2025 06:56, Christoph Hellwig wrote:

  		trace_xfs_reflink_end_cow_error(ip, error,_RET_IP_);
  	return error;
  }
+int
Still a missing empty line after the previous function.



Will fix.

 Also
please add a comment what is atomic about this function and why
the regular path doesn't use it.


ok, fine

References:
- [PATCH v6 00/13] large atomic writes for xfs with CoW
  - From: John Garry
- [PATCH v6 12/13] xfs: commit CoW-based atomic writes atomically
  - From: John Garry
- Re: [PATCH v6 12/13] xfs: commit CoW-based atomic writes atomically
  - From: Christoph Hellwig