> iomap->flags |= IOMAP_F_NEW; > > + if (flags & IOMAP_ATOMIC) > + iomap->flags |= IOMAP_F_ATOMIC_BIO; > + Add a comment here that ext4 is always using hardware atomics? > + if (flags & IOMAP_ATOMIC) > + iomap_flags |= IOMAP_F_ATOMIC_BIO; Same here (at least for now until it is changed later). > + * IOMAP_F_ATOMIC_BIO indicates that (write) I/O needs to be issued as an > + * atomic bio, i.e. set REQ_ATOMIC. s/needs to/will be/ ?