Valerie Aurora <vaurora@xxxxxxxxxx> writes:
>> Those might be assuming that the nd->path.mnt refcnt is keeped by
>> filp after nameidata_to_filp().
>>
>> It's wrong if nameidata_to_filp() returned the error. (nd->path and
>> filp are invalid)
>>
>> Instead to use deep knowledge of nameidata_to_filp() internal, this
>> thinks the nd->path is invalid after nameidata_to_filp(). So, this
>> just take refcnt for mnt_want/drop_write().
>
> You might take a look at the patch I just posted:
>
> Subject: [RFC PATCH] VFS: Simplify truncate logic in do_filp_open()
>
> If that patch is correct, it will considerably simplify the second
> part of your patch.
[...]
>> /*
>> - * It is now safe to drop the mnt write
>> - * because the filp has had a write taken
>> - * on its behalf.
>> + * It is now safe to drop the mnt write because the filp has
>> + * had a write taken on its behalf. (NOTE: since O_TRUNC can
>> + * be used with O_RDONLY, this needs to cover truncate path)
>> */
>> - if (will_truncate)
>> - mnt_drop_write(nd.path.mnt);
>> + if (will_truncate) {
>> + mnt_drop_write(mnt_writer);
>> + mntput(mnt_writer);
>> + }
Unfortunately, no. I already noted that we can't it simply. ;)
Thanks.
--
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
