[GIT PULL] fsnotify: Revert HSM events on page fault

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



  Hello Linus,

  could you please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git fsnotify_for_v6.14-rc7

Syzbot has found out that fsnotify HSM events generated on page fault can
be generated while we already hold freeze protection for the filesystem
(when you do buffered write from a buffer which is mmapped file on the same
filesystem) which violates expectations for HSM events and could lead to
deadlocks of HSM clients with filesystem freezing. Since it's quite late in
the cycle we've decided to revert changes implementing HSM events on page
fault for now and instead just generate one event for the whole range on
mmap(2) so that HSM client can fetch the data at that moment.

Top of the tree is 252256e416de. The full shortlog is:

Amir Goldstein (6):
      fsnotify: add pre-content hooks on mmap()
      Revert "ext4: add pre-content fsnotify hook for DAX faults"
      Revert "xfs: add pre-content fsnotify hook for DAX faults"
      Revert "fsnotify: generate pre-content permission event on page fault"
      Revert "mm: don't allow huge faults for files with pre content watches"
      Revert "fanotify: disable readahead if we have pre-content watches"

The diffstat is

 fs/ext4/file.c           |  3 --
 fs/xfs/xfs_file.c        | 13 --------
 include/linux/fsnotify.h | 21 ++++++++++++
 include/linux/mm.h       |  1 -
 mm/filemap.c             | 86 ------------------------------------------------
 mm/memory.c              | 19 -----------
 mm/nommu.c               |  7 ----
 mm/readahead.c           | 14 --------
 mm/util.c                |  3 ++
 9 files changed, 24 insertions(+), 143 deletions(-)

							Thanks
								Honza

-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux