VFS has some functions with names containing "lookup_one_len" and others without the "_len". This difference has nothing to do with "len". The functions without "_len" take a "mnt_idmap" pointer. This is found in the "vfsmount" and that is an important question when choosing which to use: do you have a vfsmount, or are you "inside" the filesystem. A related question is "is permission checking relevant here?". nfsd and cachefiles *do* have a vfsmount but *don't* use the non-_len functions. They pass nop_mnt_idmap which is not correct if the vfsmount is actually idmaped. For cachefiles it probably (?) doesn't matter as the accesses to the backing filesystem are always does with elevated privileged (?). For nfsd it would matter if anyone exported an idmapped filesystem. I wonder if anyone has tried... These patches change the "lookup_one" functions to take a vfsmount instead of a mnt_idmap because I think that makes the intention clearer. It also renames the "_one" functions to be "_noperm" and removes the permission checking completely. In all cases where they are (correctly) used permission checking is irrelevant. I haven't included changes to afs because there are patches in vfs.all which make a lot of changes to lookup in afs. I think (if they are seen as a good idea) these patches should aim to land after the afs patches and any further fixup in afs can happen then. The nfsd and cachefiles patches probably should be separate. Maybe I should submit those to relevant maintainers first, and one afs, cachefiles, and nfsd changes have landed I can submit this series with appropriate modifications. May main question for review is : have I understood mnt_idmap correctly? These patches are based on vfs-6.15.async.dir as they touch mkdir related code. There is a small conflict with the recently posted patch to remove locking from try_lookup_one_len() calls. Thanks, NeilBrown [PATCH 1/8] VFS: improve interface for lookup_one functions [PATCH 2/8] nfsd: Use lookup_one() rather than lookup_one_len() [PATCH 3/8] nfsd: use correct idmap for all accesses. [PATCH 4/8] cachefiles: Use lookup_one() rather than lookup_one_len() [PATCH 5/8] cachefiles: use correct mnt_idmap [PATCH 6/8] VFS: rename lookup_one_len() family to lookup_noperm() [PATCH 7/8] Use try_lookup_noperm() instead of d_hash_and_lookup() [PATCH 8/8] VFS: change lookup_one_common and lookup_noperm_common to
