Re: [PATCH] pipe_read: don't wake up the writer if the pipe is still full

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Rasmus Villemoes <ravi@xxxxxxxxx>
Subject: Re: [PATCH] pipe_read: don't wake up the writer if the pipe is still full
From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Thu, 6 Mar 2025 07:59:03 -1000
Cc: Oleg Nesterov <oleg@xxxxxxxxxx>, Mateusz Guzik <mjguzik@xxxxxxxxx>, K Prateek Nayak <kprateek.nayak@xxxxxxx>, "Sapkal, Swapnil" <swapnil.sapkal@xxxxxxx>, Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, David Howells <dhowells@xxxxxxxxxx>, WangYuli <wangyuli@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, "Shenoy, Gautham Ranjal" <gautham.shenoy@xxxxxxx>, Neeraj.Upadhyay@xxxxxxx, Ananth.narayan@xxxxxxx
In-reply-to: <87cyeu5zgk.fsf@prevas.dk>

On Wed, 5 Mar 2025 at 22:35, Rasmus Villemoes <ravi@xxxxxxxxx> wrote:
>
> On Wed, Mar 05 2025, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > and there might be other cases where the pipe_index_t size might matter.
>
> Yeah, for example
>
>       unsigned int count, head, tail, mask;
>
>       case FIONREAD:

Thanks. I've hopefully fixed this (and the FUSE issue you also
reported), and those should work correctly no on 32-bit. Knock wood.

Mind taking a look and double-checking the fixes?

                Linus

References:
- Re: [PATCH] pipe_read: don't wake up the writer if the pipe is still full
  - From: Oleg Nesterov
- Re: [PATCH] pipe_read: don't wake up the writer if the pipe is still full
  - From: Oleg Nesterov
- Re: [PATCH] pipe_read: don't wake up the writer if the pipe is still full
  - From: Sapkal, Swapnil
- Re: [PATCH] pipe_read: don't wake up the writer if the pipe is still full
  - From: Mateusz Guzik
- Re: [PATCH] pipe_read: don't wake up the writer if the pipe is still full
  - From: Mateusz Guzik
- Re: [PATCH] pipe_read: don't wake up the writer if the pipe is still full
  - From: K Prateek Nayak
- Re: [PATCH] pipe_read: don't wake up the writer if the pipe is still full
  - From: Mateusz Guzik
- Re: [PATCH] pipe_read: don't wake up the writer if the pipe is still full
  - From: Linus Torvalds
- Re: [PATCH] pipe_read: don't wake up the writer if the pipe is still full
  - From: Mateusz Guzik
- Re: [PATCH] pipe_read: don't wake up the writer if the pipe is still full
  - From: Linus Torvalds
- Re: [PATCH] pipe_read: don't wake up the writer if the pipe is still full
  - From: Oleg Nesterov
- Re: [PATCH] pipe_read: don't wake up the writer if the pipe is still full
  - From: Linus Torvalds
- Re: [PATCH] pipe_read: don't wake up the writer if the pipe is still full
  - From: Linus Torvalds
- Re: [PATCH] pipe_read: don't wake up the writer if the pipe is still full
  - From: Rasmus Villemoes

Prev by Date: Re: Is EOLDSNAPC actually generated? -- Re: Ceph and Netfslib
Next by Date: Re: [RFC] apfs: thoughts on upstreaming an out-of-tree module
Previous by thread: Re: [PATCH] pipe_read: don't wake up the writer if the pipe is still full
Next by thread: Re: [PATCH] pipe_read: don't wake up the writer if the pipe is still full
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]