On Wed, Mar 05, 2025 at 08:48:20AM +1100, NeilBrown wrote: > > Subject: [PATCH] fuse: return correct dentry for ->mkdir > > fuse already uses d_splice_alias() to ensure an appropriate dentry is > found for a newly created dentry. Now that ->mkdir can return that > dentry we do so. > > This requires changing create_new_entry() to return a dentry and > handling that change in all callers. > > Note that when create_new_entry() is asked to create anything other than > a directory we can be sure it will NOT return an alternate dentry as > d_splice_alias() only returns an alternate dentry for directories. > So we don't need to check for that case when passing one the result. > > Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx> > Signed-off-by: NeilBrown <neilb@xxxxxxx> > --- > fs/fuse/dir.c | 48 +++++++++++++++++++++++++++++++----------------- > 1 file changed, 31 insertions(+), 17 deletions(-) > > Thanks for the suggestion Miklos - this looks much better. > > Christian: could you please replace the fuse patch in your tree > with this version? Thanks. Sure, done so now. Thanks!
