On 3/1/25 10:03, Matthew Wilcox wrote: > On Sat, Mar 01, 2025 at 09:15:53AM +0800, Chao Yu wrote: >>> struct page *f2fs_get_node_page(struct f2fs_sb_info *sbi, pgoff_t nid) >>> { >>> - return __get_node_page(sbi, nid, NULL, 0); >>> + struct folio *folio = __get_node_folio(sbi, nid, NULL, 0); >>> + >> >> if (IS_ERR(folio)) >> return ERR_CAST(folio)); >> >>> + return &folio->page; > > No need. It'll probably generate the saame code (or if not, it'll > generate worse code) and this wrapper function has to be deleted in > the next six to nine months anyway. We use this idiom extensively. Oh, correct, seems return value '&folio->page' is equal to value of folio as I checked. Thanks,