Al, Andrew, Could you please pick this one up (unless you disagree with it)? Thanks! -- Dmitry VFS: clarify that nonseekable_open() will never fail Acked-by: Arnd Bergmann <arnd@xxxxxxxx> Acked-by: John Kacur <jkacur@xxxxxxxxxx> Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx> --- fs/open.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/fs/open.c b/fs/open.c index 040cef7..02ceb73 100644 --- a/fs/open.c +++ b/fs/open.c @@ -1200,7 +1200,9 @@ EXPORT_SYMBOL(generic_file_open); /* * This is used by subsystems that don't want seekable - * file descriptors + * file descriptors. The function is not supposed to ever fail, the only + * reason it returns an 'int' and not 'void' is so that it can be plugged + * directly into file_operations structure. */ int nonseekable_open(struct inode *inode, struct file *filp) { -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html