On Wed, 26 Feb 2025, Jan Kara wrote: > On Mon 24-02-25 21:20:31, Al Viro wrote: > > It has two possible values - one for "forced lookup" entries, another > > for the normal ones. We'd be better off with that as an explicit > > flag anyway and in addition to that it opens some fun possibilities > > with ->d_op and ->d_flags handling. > > > > Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > > FWIW I went through the patches and I like them. They look mostly > straightforward enough to me and as good simplifications. > Ditto. Nice clean-up It might be good to document s_d_flags and particularly the value of setting DCACHE_DONTCACHE. That flag is documented in the list of DCACHE_ flags, but making the connection that it can usefully be put in s_d_flags might be a step to far for many. Thanks, NeilBrown