[PATCH 0/3] mount: handle mount propagation for detached mount trees

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



In commit ee2e3f50629f ("mount: fix mounting of detached mounts onto
targets that reside on shared mounts") I fixed a bug where propagating
the source mount tree of an anonymous mount namespace into a target
mount tree of a non-anonymous mount namespace could be used to trigger
an integer overflow in the non-anonymous mount namespace causing any new
mounts to fail.

The cause of this was that the propagation algorithm was unable to
recognize mounts from the source mount tree that were already propagated
into the target mount tree and then reappeared as propagation targets
when walking the destination propagation mount tree.

When fixing this I disabled mount propagation into anonymous mount
namespaces. Make it possible for anonymous mount namespace to receive
mount propagation events correctly. This is no also a correctness issue
now that we allow mounting detached mount trees onto detached mount
trees.

Mark the source anonymous mount namespace with MNTNS_PROPAGATING
indicating that all mounts belonging to this mount namespace are
currently in the process of being propagated and make the propagation
algorithm discard those if they appear as propagation targets.

Signed-off-by: Christian Brauner <brauner@xxxxxxxxxx>
---
Christian Brauner (3):
      mount: handle mount propagation for detached mount trees
      selftests: add test for detached mount tree propagation
      selftests: test subdirectory mounting

 fs/mount.h                                         |   7 +
 fs/namespace.c                                     |  42 ++++--
 fs/pnode.c                                         |  10 +-
 fs/pnode.h                                         |   2 +-
 .../selftests/mount_setattr/mount_setattr_test.c   | 151 +++++++++++++++------
 5 files changed, 146 insertions(+), 66 deletions(-)
---
base-commit: 379487e17ca406b47392e7ab6cf35d1c3bacb371
change-id: 20250225-work-mount-propagation-bb557c92d509





[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux