On Tue, Feb 18 2025, Jan Kara wrote: > On Sun 16-02-25 16:50:07, Luis Henriques wrote: >> Signed-off-by: Luis Henriques <luis@xxxxxxxxxx> > > Please use evict_inodes(). It is already exported and does exactly the same > these days. We should really merge the patch deleting invalidate_inodes() > :) Thank you for the suggestion, Jan. Yeah that makes sense, of course. However, since it's still not clear what's the future of this patchset will be, I'll hold on re-sending it for now, but I'll definitely replace invalidate_inodes() in a future revision. Cheers, -- Luís > > Honza > >> --- >> fs/inode.c | 1 + >> fs/internal.h | 1 - >> include/linux/fs.h | 1 + >> 3 files changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/fs/inode.c b/fs/inode.c >> index 5587aabdaa5e..88387ecb2c34 100644 >> --- a/fs/inode.c >> +++ b/fs/inode.c >> @@ -939,6 +939,7 @@ void invalidate_inodes(struct super_block *sb) >> >> dispose_list(&dispose); >> } >> +EXPORT_SYMBOL(invalidate_inodes); >> >> /* >> * Isolate the inode from the LRU in preparation for freeing it. >> diff --git a/fs/internal.h b/fs/internal.h >> index e7f02ae1e098..7cb515cede3f 100644 >> --- a/fs/internal.h >> +++ b/fs/internal.h >> @@ -207,7 +207,6 @@ bool in_group_or_capable(struct mnt_idmap *idmap, >> * fs-writeback.c >> */ >> extern long get_nr_dirty_inodes(void); >> -void invalidate_inodes(struct super_block *sb); >> >> /* >> * dcache.c >> diff --git a/include/linux/fs.h b/include/linux/fs.h >> index 2c3b2f8a621f..ff016885646e 100644 >> --- a/include/linux/fs.h >> +++ b/include/linux/fs.h >> @@ -3270,6 +3270,7 @@ extern void discard_new_inode(struct inode *); >> extern unsigned int get_next_ino(void); >> extern void evict_inodes(struct super_block *sb); >> void dump_mapping(const struct address_space *); >> +extern void invalidate_inodes(struct super_block *sb); >> >> /* >> * Userspace may rely on the inode number being non-zero. For example, glibc > -- > Jan Kara <jack@xxxxxxxx> > SUSE Labs, CR
