"Danilo Krummrich" <dakr@xxxxxxxxxx> writes: > On Fri, Feb 07, 2025 at 08:58:25AM -0500, Tamir Duberstein wrote: >> Allow implementors to specify the foreign pointer type; this exposes >> information about the pointed-to type such as its alignment. >> >> This requires the trait to be `unsafe` since it is now possible for >> implementors to break soundness by returning a misaligned pointer. >> >> Encoding the pointer type in the trait (and avoiding pointer casts) >> allows the compiler to check that implementors return the correct >> pointer type. This is preferable to directly encoding the alignment in >> the trait using a constant as the compiler would be unable to check it. >> >> Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx> >> Reviewed-by: Andreas Hindborg <a.hindborg@xxxxxxxxxx> >> Reviewed-by: Fiona Behrens <me@xxxxxxxxxx> > > I know that Andreas also asked you to pick up the RBs from [1], but - without > speaking for any of the people above - given that you changed this commit after > you received all those RBs you should also consider dropping them. Especially, > since you do not mention the changes you did for this commit in the version > history. > > Just to be clear, often it is also fine to keep tags for minor changes, but then > you should make people aware of them in the version history, such that they get > the chance to double check. > > [1] https://lore.kernel.org/rust-for-linux/20250131-configfs-v1-1-87947611401c@xxxxxxxxxx/ > As long as the commit was not radically changed, I see no point in dropping the commit trailers. Same policy as for dropping review tags when issuing a new version of a series should be applied. Best regards, Andreas Hindborg
