On Mon, Feb 17, 2025 at 10:50:10AM -0500, Tamir Duberstein wrote: > On Mon, Feb 17, 2025 at 9:52 AM Danilo Krummrich <dakr@xxxxxxxxxx> wrote: > > > > On Mon, Feb 17, 2025 at 09:47:14AM -0500, Tamir Duberstein wrote: > > > On Mon, Feb 17, 2025 at 9:37 AM Danilo Krummrich <dakr@xxxxxxxxxx> wrote: > > > > You're free to do the change (I encourage that), but that's of course up to you. > > > > > > I'll create a "good first issue" for it in the RfL repository. > > > > That's a good idea -- thanks. > > What do you think about enabling clippy::ptr_as_ptr? > https://rust-lang.github.io/rust-clippy/master/index.html#ptr_as_ptr Seems reasonable to me, but I'm a bit out of competence here. I know some lints are not stable and hence need to be treated with care, though this doesn't seem to be one of them. Additionally, I think the lint would need to be supported by all compiler versions the kernel supports currently, which also seems to be the case (added in: 1.51.0). > > Do we currently enable any non-default clippy lints? Yes, you can check the root Makefile [1]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Makefile?h=v6.14-rc3#n471
