On Thu, 11 Feb 2010, Christoph Hellwig wrote: > On Wed, Feb 10, 2010 at 12:15:53PM +0100, Miklos Szeredi wrote: > > - renamed flag to UMOUNT_NOFOLLOW > > - added UMOUNT_UNUSED for feature detection > > Umm, why? MNT_ certainly isn't the best naming for unmount flags, > but switching convention after we had a few doesn't make any sense. It's not just bad naming, having another set of unrelated flags with the same prefix *and* in close proximity to each other is asking for trouble. We could rename all the umount flags, and leave userspace do #defines for backward compat. It's not as if this was some widely used or portable API. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html