Re: [RFC PATCH 3/4] ceph: introduce ceph_submit_write() method

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 04, 2025 at 04:02:48PM -0800, Viacheslav Dubeyko wrote:
> This patch implements refactoring of ceph_submit_write()
> and also it solves the second issue.
> 
> Signed-off-by: Viacheslav Dubeyko <Slava.Dubeyko@xxxxxxx>

This kind of giant refactoring to solve a bug is a really bad idea.
First, it's going to need to be backported to older kernels.  How far
back?  You need to identify that with a Fixes: line.

It's also really hard to review and know whether it's right.  You might
have introduced several new bugs while doing it.  In general, bugfixes
first, refactor later.  I *think* this means we can do without 1/7 of
the patches I resent earlier today, but it's really hard to be sure.




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux