RE: [PATCH v2 5/7] ceph: Convert ceph_readdir_cache_control to store a folio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2025-02-14 at 19:34 +0000, Matthew Wilcox wrote:
> On Fri, Feb 14, 2025 at 07:10:26PM +0000, Viacheslav Dubeyko wrote:
> > > -		cache_ctl->page = find_lock_page(&dir->i_data, ptr_pgoff);
> > > -		if (!cache_ctl->page) {
> > > +		cache_ctl->folio = filemap_lock_folio(&dir->i_data, ptr_pgoff);
> > > +		if (IS_ERR(cache_ctl->folio)) {
> > > +			cache_ctl->folio = NULL;
> > >  			doutc(cl, " page %lu not found\n", ptr_pgoff);
> > 
> > Maybe, we need to change debug output here too?
> > 
> > doutc(cl, " folio %lu not found\n", ptr_pgoff);
> 
> I'm happy to make that change for the next version, or for somebody to
> make that change while applying the patches.

It's not critical one. The patch looks good.

Reviewed-by: Viacheslav Dubeyko <Slava.Dubeyko@xxxxxxx>

Thanks,
Slava.





[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux