Re: [RFC PATCH 2/2] watch_queue: Fix pipe accounting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/14/25 10:49 AM, David Howells wrote:
> Eric Sandeen <sandeen@xxxxxxxxxx> wrote:
> 
>> -	if (!pipe_has_watch_queue(pipe)) {
>> -		pipe->max_usage = nr_slots;
>> -		pipe->nr_accounted = nr_slots;
>> -	}
>> +	pipe->max_usage = nr_slots;
>> +	pipe->nr_accounted = nr_slots;
> 
> Hmmm...   The pipe ring is supposed to have some spare capacity when used as a
> watch queue so that you can bung at least a few messages into it.

If the pipe has an original number of buffers on it, and
then watch_queue_set_size adjusts that number - where does
the spare capacity come from? Who adds it / where?

Thanks,
-Eric

> David
> 
> 





[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux