Re: [PATCH] fuse: don't set file->private_data in fuse_conn_waiting_read

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 14 Feb 2025 at 13:58, Jeff Layton <jlayton@xxxxxxxxxx> wrote:

> It's just an unnecessary assignment. Nothing will look at or use
> private_data in this codepath, so there is no need to set it.

I think the reason it was done this way is to return a sane value even
in the case of small reads (i.e. char-by-char).  It's unlikely to
matter in real life, but removing it is not a big enough win to be
worth risking it.

Thanks,
Miklos




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux