On Fri, 14 Feb 2025 at 13:58, Jeff Layton <jlayton@xxxxxxxxxx> wrote: > It's just an unnecessary assignment. Nothing will look at or use > private_data in this codepath, so there is no need to set it. I think the reason it was done this way is to return a sane value even in the case of small reads (i.e. char-by-char). It's unlikely to matter in real life, but removing it is not a big enough win to be worth risking it. Thanks, Miklos