On Thu, Feb 13, 2025 at 04:09:31AM +0000, Al Viro wrote: > > > + } while (PTR_ERR_OR_ZERO(sdentry) == -EEXIST); /* need negative lookup */ > > > > What's wrong with sdentry == ERR_PTR(-EEXIST)? > > BTW, do you need to mess with NFS_DATA_BLOCKED with that thing in place? That'd be NFS_FSDATA_BLOCKED, of course, and apparently it's still needed for the "not busy, not sillyrenaming" cases in rename and unlink... Nevermind, just looking into getting rid of d_drop/d_rehash on the AFS side of things.