Re: [PATCH 05/10] dax: advance the iomap_iter on zero range

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Wed, Feb 12, 2025 at 08:57:07AM -0500, Brian Foster wrote:
> @@ -1372,33 +1371,35 @@ static s64 dax_zero_iter(struct iomap_iter *iter, bool *did_zero)
>  	 */
>  	if (iomap->flags & IOMAP_F_SHARED)
>  		invalidate_inode_pages2_range(iter->inode->i_mapping,
> -					      pos >> PAGE_SHIFT,
> -					      (pos + length - 1) >> PAGE_SHIFT);
> +					      iter->pos >> PAGE_SHIFT,
> +					      (iter->pos + length - 1) >> PAGE_SHIFT);

Relaly long line here.  I think this would benefit from normal two
tab argument continuation indentation (and a less stupid calling
convention for invalidate_inode_pages2_range, but that's a different
story).