Re: [RFC PATCH 6/6] debugfs: Replace debugfs_node #define with struct wrapping dentry

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 09, 2025 at 09:20:26PM -0800, David Reaver wrote:

> +static inline struct debugfs_node *dentry_to_node(struct dentry *dentry)
> +{
> +	return container_of(dentry, struct debugfs_node, dentry);
> +}

No.  And you don't have any fields left in struct dentry to replace
that with following a pointer.

Again, do not embed struct dentry into any other object; you are not just
doing that on temporary basis, it's left in that form by the end of the
series.  No go.

NAKed-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux