On 2/8/25 5:24 PM, Pavel Begunkov wrote:
> On 2/8/25 23:27, Pavel Begunkov wrote:
> ...
>> But it might be better to just poll the epoll fd, reuse all the
>> io_uring polling machinery, and implement IO_URING_F_MULTISHOT for
>> the epoll opcode.
>>
>> epoll_issue(issue_flags) {
>> if (!(flags & IO_URING_F_MULTISHOT))
>> return -EAGAIN;
>>
>> res = epoll_check_events();
>> post_cqe(res);
>> etc.
>> }
>>
>> I think that would make this patch quite trivial, including
>> the multishot mode.
>
> Something like this instead of the last patch. Completely untested,
> the eventpoll.c hunk is dirty might be incorrect, need to pass the
> right mask for polling, and all that. At least it looks simpler,
> and probably doesn't need half of the prep patches.
I like that idea! I'll roll with it and get it finalized and then do
some testing.
--
Jens Axboe
