Re: [PATCH] ceph: add process/thread ID into debug output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Alex Markuze <amarkuze@xxxxxxxxxx>

On Thu, Feb 6, 2025 at 9:11 PM Viacheslav Dubeyko <slava@xxxxxxxxxxx> wrote:
>
> From: Viacheslav Dubeyko <Slava.Dubeyko@xxxxxxx>
>
> Process/Thread ID (pid) is crucial and essential info
> during the debug and bug fix. It is really hard
> to analyze the debug output without these details.
> This patch addes PID info into the debug output.
>
> Signed-off-by: Viacheslav Dubeyko <Slava.Dubeyko@xxxxxxx>
> ---
>  include/linux/ceph/ceph_debug.h | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/ceph/ceph_debug.h b/include/linux/ceph/ceph_debug.h
> index 5f904591fa5f..6292db198f61 100644
> --- a/include/linux/ceph/ceph_debug.h
> +++ b/include/linux/ceph/ceph_debug.h
> @@ -16,13 +16,15 @@
>
>  # if defined(DEBUG) || defined(CONFIG_DYNAMIC_DEBUG)
>  #  define dout(fmt, ...)                                               \
> -       pr_debug("%.*s %12.12s:%-4d : " fmt,                            \
> +       pr_debug("pid %d %.*s %12.12s:%-4d : " fmt,                     \
> +                current->pid,                                          \
>                  8 - (int)sizeof(KBUILD_MODNAME), "    ",               \
>                  kbasename(__FILE__), __LINE__, ##__VA_ARGS__)
>  #  define doutc(client, fmt, ...)                                      \
> -       pr_debug("%.*s %12.12s:%-4d : [%pU %llu] " fmt,                 \
> +       pr_debug("pid %d %.*s %12.12s:%-4d %s() : [%pU %llu] " fmt,     \
> +                current->pid,                                          \
>                  8 - (int)sizeof(KBUILD_MODNAME), "    ",               \
> -                kbasename(__FILE__), __LINE__,                         \
> +                kbasename(__FILE__), __LINE__, __func__,               \
>                  &client->fsid, client->monc.auth->global_id,           \
>                  ##__VA_ARGS__)
>  # else
> --
> 2.48.0
>






[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux