On Wed, 05 Feb 2025 15:34:28 -0600, Eric Sandeen wrote: > Notes: > > pstore used mount_single, which used to transparently do a > remount operation on a fresh mount of an existing superblock. > The new get_tree_single does not do this, but prior discussion > on fsdevel seems to indicate that this isn't expected to be a > problem. We can watch for issues. > > [...] Looks good to me. Thanks for enabling us to get rid of a bunch of code. --- Applied to the vfs-6.15.mount.api branch of the vfs/vfs.git tree. Patches in the vfs-6.15.mount.api branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs-6.15.mount.api [1/4] pstore: convert to the new mount API https://git.kernel.org/vfs/vfs/c/f584714cffb9 [2/4] vfs: Convert devpts to use the new mount API https://git.kernel.org/vfs/vfs/c/cc0876f817d6 [3/4] devtmpfs: replace ->mount with ->get_tree in public instance https://git.kernel.org/vfs/vfs/c/cb0e0a8bf4e1 [4/4] vfs: remove some unused old mount api code https://git.kernel.org/vfs/vfs/c/bdfa77e7c6bf