On Wed, Feb 05, 2025 at 05:16:37PM +0100, Oleg Nesterov wrote: > On 02/05, Linus Torvalds wrote: > > > > On Wed, 5 Feb 2025 at 07:34, Oleg Nesterov <oleg@xxxxxxxxxx> wrote: > > > > > > So that fifos and anonymous pipes could have different f_op methods. > > > Preparation to simplify the next patch. > > > > Looks good, except: > > > > > +++ b/fs/internal.h > > > extern const struct file_operations pipefifo_fops; > > > +extern const struct file_operations pipeanon_fops; > > > > I think this should just be 'static' to inside fs/pipe.c, no? > > I swear, this is what I did initially ;) > > But then for some reason I thought someone would ask me to export > pipeanon_fops along with pipefifo_fops for consistency. > > OK, I will wait for other reviews and send V3. It's fine. Minor things like this I can just fix myself when pulling this. There's no need to generate more mail traffic for this.
