On Wed, Feb 05, 2025 at 05:21:34PM +0530, Anuj Gupta wrote: > On Tue, Feb 04, 2025 at 06:39:14AM +0100, Christoph Hellwig wrote: > > On Mon, Feb 03, 2025 at 08:09:48PM +0530, Anuj Gupta wrote: > > > + if (bi->csum_type == BLK_INTEGRITY_CSUM_IP) > > > + bip->bip_flags |= BIP_IP_CHECKSUM; > > > > We'll also need to set the BIP_CHECK_GUARD flag here I think. > > Right, I think this patch should address the problem [*] > I couldn't test this patch, as nvme-tcp doesn't support T10-PI and so > does rdma_rxe. I don't have rdma h/w to test this. > It would be great if someone can give this a run. I'll add support to nvmet-loop, which should make testing either. Note that the SCSI target code has the same issues and might be a little easier to test.
