Having to synchronize the number of ctl_table array elements with the size in the declaration can lead to discrepancies between the two values. Since commit d7a76ec87195 ("sysctl: Remove check for sentinel element in ctl_table arrays"), the calculation of the ctl_table array size is done solely by the ARRAY_SIZE macro removing the need for the size in the declaration. Remove the size for the aligment_tbl declaration and const qualify the array for good measure. Signed-off-by: Joel Granados <joel.granados@xxxxxxxxxx> --- arch/csky/abiv1/alignment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/csky/abiv1/alignment.c b/arch/csky/abiv1/alignment.c index e5b8b4b2109a..aee904833dec 100644 --- a/arch/csky/abiv1/alignment.c +++ b/arch/csky/abiv1/alignment.c @@ -300,7 +300,7 @@ void csky_alignment(struct pt_regs *regs) force_sig_fault(SIGBUS, BUS_ADRALN, (void __user *)addr); } -static struct ctl_table alignment_tbl[5] = { +static const struct ctl_table alignment_tbl[] = { { .procname = "kernel_enable", .data = &align_kern_enable, -- 2.44.2 I'll queue this up for the next release unless you take it in now. > > in arch/csky/abiv1/alignment.c that didn't get converted. > > And a couple of rdma drivers (iwcm_ctl_table and ucma_ctl_table), but These two are accounted for. I'll get to them eventually. > maybe those weren't converted due to being in the "net" address space? > > Anyway, taken as-is, I'm just noting the lacking cases. > > Linus -- Joel Granados