Re: [PATCH 3/3] lockref: remove count argument of lockref_init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 29, 2025 at 06:19:39PM +0100, Andreas Gruenbacher wrote:
> On Wed, Jan 29, 2025 at 4:44 PM Christoph Hellwig <hch@xxxxxx> wrote:
> > Maybe the lockref_init kerneldoc now needs to say that it's initialized
> > to a hold count of 1?
> 
> I always feel a bit guilty when adding a comment like "Initializes
> @lockref->count to 1" and five lines further down in the code, it says
> 'lockref->count = 1'. But okay.

It reads a bit odd, but kerneldoc comments aren't just for the reader
of the code - they also get extraced into rendered documentation.




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux