On Wed, Jan 29, 2025 at 06:19:39PM +0100, Andreas Gruenbacher wrote: > On Wed, Jan 29, 2025 at 4:44 PM Christoph Hellwig <hch@xxxxxx> wrote: > > Maybe the lockref_init kerneldoc now needs to say that it's initialized > > to a hold count of 1? > > I always feel a bit guilty when adding a comment like "Initializes > @lockref->count to 1" and five lines further down in the code, it says > 'lockref->count = 1'. But okay. It reads a bit odd, but kerneldoc comments aren't just for the reader of the code - they also get extraced into rendered documentation.