> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Thursday, January 30, 2025 12:55 PM
> To: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> Cc: Borah, Chaitanya Kumar <chaitanya.kumar.borah@xxxxxxxxx>; intel-
> gfx@xxxxxxxxxxxxxxxxxxxxx; intel-xe@xxxxxxxxxxxxxxxxxxxxx; Kurmi, Suresh
> Kumar <suresh.kumar.kurmi@xxxxxxxxx>; Saarinen, Jani
> <jani.saarinen@xxxxxxxxx>; linux-fsdevel@xxxxxxxxxxxxxxx; Alexander Gordeev
> <agordeev@xxxxxxxxxxxxx>
> Subject: Re: Regression on linux-next (next-20250120)
>
> On Wed, Jan 29, 2025 at 07:19:37PM +0000, Al Viro wrote:
> > On Wed, Jan 29, 2025 at 08:13:02AM +0100, Greg Kroah-Hartman wrote:
> >
> > > > Both are needed, actually. Slightly longer term I would rather
> > > > split full_proxy_{read,write,lseek}() into short and full variant,
> > > > getting rid of the "check which pointer is non-NULL" and killed
> > > > the two remaining users of debugfs_real_fops() outside of
> > > > fs/debugfs/file.c; then we could union these ->..._fops pointers,
> > > > but until then they need to be initialized.
> > > >
> > > > And yes, ->methods obviously needs to be initialized.
> > > >
> > > > Al, bloody embarrassed ;-/
> > >
> > > No worries, want to send a patch to fix both of these up so we can
> > > fix up Linus's tree now?
> >
> > [PATCH] Fix the missing initializations in __debugfs_file_get()
> >
> > both method table pointers in debugfs_fsdata need to be initialized,
> > obviously, and calculating the bitmap of present methods would also go
> > better if we start with initialized state.
> >
> > Fixes: 41a0ecc0997c "debugfs: get rid of dynamically allocation proxy_ops"
> > Fucked-up-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> > ---
>
> Thanks, now queued up.
We can confirm that this change works.
Regards
Chaitanya
>
> greg k-h
